Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi…

components/autofill/renderer/form_autofill_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/form_autofill_util.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 572 matching lines @@
   NOTREACHED();
   return "UNKNOWN";
 }
 
 }  // namespace
 
 namespace autofill {
 
 const size_t kMaxParseableFields = 100;
 
-// In HTML5, all text fields except password are text input fields to
-// autocomplete.
+// Include password fields as TextInput fields. Password fields will be filtered
+// out in browser process before sending them accross to Autofill server in
+// regular Autofill.

[Ilya Sherman, 2013/03/15 23:42:35]

This comment doesn't seem very useful except to someone looking at the diff for
this CL.  I'd change it to something like "All text fields, including password
fields, should be extracted."

[Raman Kakilate, 2013/03/18 17:54:00]

Done.

 bool IsTextInput(const WebInputElement* element) {
   if (!element)
     return false;
 
-  return element->isTextField() && !element->isPasswordField();
+  return element->isTextField();

[Ilya Sherman, 2013/03/15 23:42:35]

nit: "return element && element->isTextField();"

[Raman Kakilate, 2013/03/18 17:54:00]

Done.

 }
 
 bool IsSelectElement(const WebFormControlElement& element) {
   // Is static for improving performance.
   CR_DEFINE_STATIC_LOCAL(WebString, kSelectOne, ("select-one"));
   return element.formControlType() == kSelectOne;
 }
 
 bool IsCheckableElement(const WebInputElement* element) {
   if (!element)
@@ skipping 102 matching lines @@
 
   const WebInputElement* input_element = toWebInputElement(&element);
   if (IsAutofillableInputElement(input_element)) {
     if (IsTextInput(input_element))
       field->max_length = input_element->maxLength();
 
     field->is_autofilled = input_element->isAutofilled();
     field->is_focusable = input_element->isFocusable();
     field->should_autocomplete = input_element->autoComplete();
     field->is_checkable = IsCheckableElement(input_element);
+
+    // Explicitly mark password fields as non autofillable.
+    if (input_element->isPasswordField())
+      field->is_password_field = true;
   } else if (extract_mask & EXTRACT_OPTIONS) {
     // Set option strings on the field if available.
     DCHECK(IsSelectElement(element));
     const WebSelectElement select_element = element.toConst<WebSelectElement>();
     GetOptionStringsFromElement(select_element,
                                 &field->option_values,
                                 &field->option_contents);
   }
 
   if (!(extract_mask & EXTRACT_VALUE))
@@ skipping 291 matching lines @@
       continue;
 
     if (input_element->isAutofilled())
       return true;
   }
 
   return false;
 }
 
 }  // namespace autofill