Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: Source/bindings/core/v8/V8GCController.cpp

Issue 1272083003: Oilpan: Make the GC heuristics saner Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 // for tests that force GCs from JavaScript to verify that objects die 387 // for tests that force GCs from JavaScript to verify that objects die
388 // when expected, or when handling memory pressure notifications. 388 // when expected, or when handling memory pressure notifications.
389 bool forceGC = flags & v8::kGCCallbackFlagForced; 389 bool forceGC = flags & v8::kGCCallbackFlagForced;
390 390
391 // FIXME: It would be nice if the GC callbacks passed the Isolate directly.. .. 391 // FIXME: It would be nice if the GC callbacks passed the Isolate directly.. ..
392 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 392 v8::Isolate* isolate = v8::Isolate::GetCurrent();
393 if (type == v8::kGCTypeScavenge) { 393 if (type == v8::kGCTypeScavenge) {
394 minorGCEpilogue(isolate); 394 minorGCEpilogue(isolate);
395 } else if (type == v8::kGCTypeMarkSweepCompact) { 395 } else if (type == v8::kGCTypeMarkSweepCompact) {
396 majorGCEpilogue(isolate); 396 majorGCEpilogue(isolate);
397 if (!forceGC)
398 ThreadState::current()->didV8MajorGC();
399 } 397 }
400 398
401 if (forceGC) { 399 if (forceGC) {
402 // This single GC is not enough for two reasons: 400 // This single GC is not enough for two reasons:
403 // (1) The GC is not precise because the GC scans on-stack pointers co nservatively. 401 // (1) The GC is not precise because the GC scans on-stack pointers co nservatively.
404 // (2) One GC is not enough to break a chain of persistent handles. It 's possible that 402 // (2) One GC is not enough to break a chain of persistent handles. It 's possible that
405 // some heap allocated objects own objects that contain persistent handles 403 // some heap allocated objects own objects that contain persistent handles
406 // pointing to other heap allocated objects. To break the chain, w e need multiple GCs. 404 // pointing to other heap allocated objects. To break the chain, w e need multiple GCs.
407 // 405 //
408 // Regarding (1), we force a precise GC at the end of the current event loop. So if you want 406 // Regarding (1), we force a precise GC at the end of the current event loop. So if you want
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 Visitor* m_visitor; 499 Visitor* m_visitor;
502 }; 500 };
503 501
504 void V8GCController::traceDOMWrappers(v8::Isolate* isolate, Visitor* visitor) 502 void V8GCController::traceDOMWrappers(v8::Isolate* isolate, Visitor* visitor)
505 { 503 {
506 DOMWrapperTracer tracer(visitor); 504 DOMWrapperTracer tracer(visitor);
507 v8::V8::VisitHandlesWithClassIds(isolate, &tracer); 505 v8::V8::VisitHandlesWithClassIds(isolate, &tracer);
508 } 506 }
509 507
510 } // namespace blink 508 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/WrapperTypeInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698