Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: pkg/analysis_server/lib/src/services/correction/organize_directives.dart

Issue 1272013002: Simplify directive's optimizer edit. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/organize_directives_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/correction/organize_directives.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/organize_directives.dart b/pkg/analysis_server/lib/src/services/correction/organize_directives.dart
index d3de3ea62748220f583aece528ff848f713802b5..b12ecb138b6dcebba5b05aa8874da0709bc69883 100644
--- a/pkg/analysis_server/lib/src/services/correction/organize_directives.dart
+++ b/pkg/analysis_server/lib/src/services/correction/organize_directives.dart
@@ -9,6 +9,7 @@ import 'package:analysis_server/src/services/correction/strings.dart';
import 'package:analyzer/src/generated/ast.dart';
import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/scanner.dart';
+import 'dart:math';
/**
* Organizer of directives in the [unit].
@@ -36,16 +37,9 @@ class DirectiveOrganizer {
// prepare edits
List<SourceEdit> edits = <SourceEdit>[];
if (code != initialCode) {
- int prefixLength = findCommonPrefix(initialCode, code);
int suffixLength = findCommonSuffix(initialCode, code);
- String prefix = code.substring(0, prefixLength);
- String suffix = code.substring(code.length - suffixLength, code.length);
- int commonLength = findCommonOverlap(prefix, suffix);
- suffixLength -= commonLength;
- SourceEdit edit = new SourceEdit(
- prefixLength,
- initialCode.length - suffixLength - prefixLength,
- code.substring(prefixLength, code.length - suffixLength));
+ SourceEdit edit = new SourceEdit(0, initialCode.length - suffixLength,
+ code.substring(0, code.length - suffixLength));
edits.add(edit);
}
return edits;
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/organize_directives_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698