Chromium Code Reviews Chromium Code Reviews
Issue
12720010:
Clean up control of perf governor (Closed)
DescriptionClean up control of perf governor
The perf governor was previously controlled by the PerfTestSetup class,
which set the perf governor to 'performance' mode in Startup() and
reset it to its original value on TearDown(). This had a number of
problems:
- We ended up with TearDown() being used in place of SetUp() when
starting tests where we didn't want performance mode. This looks
strange.
- There was no explicit way of setting the device's default
performance mode. We would call TearDown() and hope for the best. This
would not work if the device was already in performance mode at the
start of the test. We think this is sometimes happening on the
performance bots.
- SetUp() also cleared the caches, which should have no direct
connection with setting the performance mode.
This patch creates two new classes, PerfControl and CacheControl, to
manage the perf governor and cache. These replace PerfTestSetup.
PerfTestSetup has not yet been deleted to avoid the need for simultaneous
commits on the upstream and downstream repositories.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189097
Patch Set 1 #
Total comments: 6
Patch Set 2 : Clean up control of perf governor - code review fixes #
Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||
