pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart - Issue 1271953003: dart2js: Add a header to the output of the startup emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

Issue 1271953003: dart2js: Add a header to the output of the startup emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add flavor section to generatedBy comment. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/headers.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

index f0b5a784f40891b31ef64e1680cfc755d14dee5f..c4e0012d3e9f053d5449b061bca48f4ec1a58f45 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

@@ -518,9 +518,10 @@ class FragmentEmitter {

js.Statement emitDeferredInitializerGlobal(Map loadMap) {

if (loadMap.isEmpty) return new js.Block.empty();

- return js.js.statement("""

- if (typeof(${ModelEmitter.deferredInitializersGlobal}) === 'undefined')

- var ${ModelEmitter.deferredInitializersGlobal} = Object.create(null);""");

+ String global = ModelEmitter.deferredInitializersGlobal;

+ return js.js.statement(

+ "if (typeof($global) === 'undefined') var # = Object.create(null);",

+ new js.VariableDeclaration(global, allowRename: false));

}

/// Emits all holders, except for the static-state holder.

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/headers.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart » ('j') | no next file with comments »