Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1271933002: Namespace clean-up in histogram_tester_unittest.cc (Closed)

Created:
5 years, 4 months ago by vabr (Chromium)
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Namespace clean-up in histogram_tester_unittest.cc This CL introduces an anonymous namespace instead of using "static" for global constants. It is a follow-up to https://codereview.chromium.org/1264123002/. R=thestig@chromium.org BUG=473689 Committed: https://crrev.com/3db30f9fa710e97054703cee6909533b5bb0a96c Cr-Commit-Position: refs/heads/master@{#341732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M base/test/histogram_tester_unittest.cc View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vabr (Chromium)
Hi Lei, PTAL, this is a follow-up to https://codereview.chromium.org/1264123002/#msg18. Cheers, Vaclav
5 years, 4 months ago (2015-08-04 10:23:40 UTC) #1
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-04 16:19:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271933002/1
5 years, 4 months ago (2015-08-04 16:19:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 16:26:53 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 16:27:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3db30f9fa710e97054703cee6909533b5bb0a96c
Cr-Commit-Position: refs/heads/master@{#341732}

Powered by Google App Engine
This is Rietveld 408576698