src/IceRegAlloc.cpp - Issue 1271923002: Subzero: Slight improvement to phi lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceRegAlloc.cpp

Issue 1271923002: Subzero: Slight improvement to phi lowering. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add a TODO Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceRegAlloc.cpp

diff --git a/src/IceRegAlloc.cpp b/src/IceRegAlloc.cpp

index fad3d01795dc69c5961a82433514efbf25cdc1d7..c651ae21a07457c7ee969b9295d2b0ede05487dd 100644

--- a/src/IceRegAlloc.cpp

+++ b/src/IceRegAlloc.cpp

@@ -107,10 +107,6 @@ void LinearScan::initForGlobal() {

// it was never referenced.

if (Var->getLiveRange().isEmpty())

continue;

- // Post phi lowering register allocation is only concerned with variables

- // that are infinite-weight or pre-colored.

- if (Kind == RAK_Phi && !Var->getWeight().isInf() && !Var->hasReg())

- continue;

Var->untrimLiveRange();

Unhandled.push_back(Var);

if (Var->hasReg()) {

« no previous file with comments | « src/IceLiveness.cpp ('k') | no next file » | no next file with comments »