Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 1271903003: Remove IGNORE_ROT_AA_RECT_OPT flag (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove IGNORE_ROT_AA_RECT_OPT flag It looks like the positive version was added (SHADER_AA_FILL_RECT) but the negative version wasn't removed. Committed: https://skia.googlesource.com/skia/+/fae010266f32b715f334c8680aeada2c72d44668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robertphillips
5 years, 4 months ago (2015-08-04 12:42:46 UTC) #2
reed1
lgtm
5 years, 4 months ago (2015-08-04 14:53:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271903003/1
5 years, 4 months ago (2015-08-04 14:56:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fae010266f32b715f334c8680aeada2c72d44668
5 years, 4 months ago (2015-08-04 15:04:31 UTC) #6
mtklein_C
5 years, 4 months ago (2015-08-04 17:18:37 UTC) #8
Message was sent while issue was closed.
Can you take a look at gold?  A few sections of gold.skia.org/byblame pin a set
of changes to either this CL or Mike's GPU image readback caching.  The diffs
look like they're on rotated draws, so this is my first guess.

E.g.
https://gold.skia.org/search2?blame=fae010266f32b715f334c8680aeada2c72d44668%...

Powered by Google App Engine
This is Rietveld 408576698