Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 12719005: Sort project headers in a case-sensitive way since PRESUBMIT enforces that (Closed)

Created:
7 years, 9 months ago by jamesr
Modified:
7 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Sort project headers in a case-sensitive way since PRESUBMIT enforces that The PRESUBMIT check requires that the lines: #include "third_party/WebKit/...h" #include "third_party/skia/...h" be sorted in that order, which requires doing a case-sensitive sort. sort-headers.py was changed to do a case-insensitive sort in r139294 to avoid shuffling system header includes like these: #include <uxtheme.h> #include <Vssym32.h> This preserves that behavior only for system-style includes (those with <>). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/sort-headers.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
7 years, 9 months ago (2013-03-13 21:11:53 UTC) #1
Nico
lgtm
7 years, 9 months ago (2013-03-13 21:13:04 UTC) #2
jamesr
7 years, 9 months ago (2013-03-13 21:24:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r187945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698