Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/installer/util/util_constants.cc

Issue 1271893003: Add options to write version number to registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: start subprocess to set DisplayVersion Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/util_constants.cc
diff --git a/chrome/installer/util/util_constants.cc b/chrome/installer/util/util_constants.cc
index a1afbcd33f9cf11681db3df4695c28614aac46ef..ce2b0a057631dbbdf8517f32fbc36c0f3bbae14b 100644
--- a/chrome/installer/util/util_constants.cc
+++ b/chrome/installer/util/util_constants.cc
@@ -31,6 +31,11 @@ const char kConfigureUserSettings[] = "configure-user-settings";
// in-use Chrome should be restarted ASAP.
const char kCriticalUpdateVersion[] = "critical-update-version";
+// Setting this will delay the operation of setup by the specified number of
+// seconds. This is used when changing the DisplayVersion registry value
+// only after some time has passed, called by the MSI installer.
+const char kDelay[] = "delay";
+
// Delete user profile data. This param is useful only when specified with
// kUninstall, otherwise it is silently ignored.
const char kDeleteProfile[] = "delete-profile";
@@ -134,6 +139,12 @@ const char kRemoveChromeRegistration[] = "remove-chrome-registration";
// line flag so that we try the launch only once.
const char kRunAsAdmin[] = "run-as-admin";
+// Set the MSI-managed DisplayVersion in the registry to match Chrome's real
+// version number. The parameter to this option specifies the registry path
+// under HKLM.
+const char kSetDisplayVersionPath[] = "set-display-version-path";
+const char kSetDisplayVersionValue[] = "set-display-version-value";
+
// Combined with --uninstall, signals to setup.exe that this uninstall was
// triggered by a self-destructing Chrome.
const char kSelfDestruct[] = "self-destruct";

Powered by Google App Engine
This is Rietveld 408576698