Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: chrome/browser/chromeos/login/app_launch_controller.h

Issue 127183002: kiosk: Fix StartupAppLauncher::LaunchApp crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: per discussion Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/app_launch_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/app_launch_controller.h
diff --git a/chrome/browser/chromeos/login/app_launch_controller.h b/chrome/browser/chromeos/login/app_launch_controller.h
index be2d463d2842aaa777c85d3567b74296b53ad5e7..bc41b6651bef1b622dd0d11818c82ca77fe772f0 100644
--- a/chrome/browser/chromeos/login/app_launch_controller.h
+++ b/chrome/browser/chromeos/login/app_launch_controller.h
@@ -9,8 +9,6 @@
#include "base/basictypes.h"
#include "base/callback_forward.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
#include "base/timer/timer.h"
#include "chrome/browser/chromeos/app_mode/kiosk_app_launch_error.h"
#include "chrome/browser/chromeos/app_mode/kiosk_profile_loader.h"
@@ -32,8 +30,7 @@ class UserManager;
// coordinating loading the kiosk profile, launching the app, and
// updating the splash screen UI.
class AppLaunchController
- : public base::SupportsWeakPtr<AppLaunchController>,
- public AppLaunchSplashScreenActor::Delegate,
+ : public AppLaunchSplashScreenActor::Delegate,
public KioskProfileLoader::Delegate,
public StartupAppLauncher::Delegate,
public AppLaunchSigninScreen::Delegate,
@@ -122,6 +119,9 @@ class AppLaunchController
bool webui_visible_;
bool launcher_ready_;
+ // A timer to ensure the app splash is shown for a minimum amount of time.
+ base::OneShotTimer<AppLaunchController> splash_wait_timer_;
+
base::OneShotTimer<AppLaunchController> network_wait_timer_;
bool waiting_for_network_;
bool network_wait_timedout_;
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/app_launch_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698