Issue 127183002: kiosk: Fix StartupAppLauncher::LaunchApp crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 127183002: kiosk: Fix StartupAppLauncher::LaunchApp crash. (Closed)

Created:
6 years, 11 months ago by xiyuan

Modified:
6 years, 11 months ago

Reviewers:
Tim Song

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

kiosk: Fix StartupAppLauncher::LaunchApp crash. Speculative fix. This crash happens if we have pending OnReadyToLaunch job after CleanUp is being called. The only possible cause seems to be user manually cancels the launch while the OnReadyToLaunch job is pending. Use timer for the job and cancels it in CleanUp to fix the crash. BUG=331105 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243726

Patch Set 1 #

Patch Set 2 : per discussion #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	chrome/browser/chromeos/login/app_launch_controller.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	chrome/browser/chromeos/login/app_launch_controller.cc	View	1	5 chunks	+10 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

xiyuan

CL updated per discussion. Please take another look. Thanks.

6 years, 11 months ago (2014-01-08 22:14:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/127183002/50001

6 years, 11 months ago (2014-01-08 22:32:33 UTC) #5

Message was sent while issue was closed.

Change committed as 243726

Expand Messages | Collapse Messages