Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1271823006: Revert of GC: Refactor public incremental marking interface in heap (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of GC: Refactor public incremental marking interface in heap (patchset #6 id:100001 of https://codereview.chromium.org/1273483002/ ) Reason for revert: Fails on the MSAN builder: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/3580/steps/Check/logs/RegExpInterruption Likely due to lack of initialization of IncrementalMarking::gc_callback_flags_. Original issue's description: > GC: Refactor incremental marking interface from heap > > BUG= > > Committed: https://crrev.com/c9fcaeb336919ce4b76fded8c8059457e9820250 > Cr-Commit-Position: refs/heads/master@{#30009} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0215fb56f4c75b054116632039edbff0d7f40373 Cr-Commit-Position: refs/heads/master@{#30011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -79 lines) Patch
M src/heap/heap.h View 2 chunks +4 lines, -15 lines 0 comments Download
M src/heap/heap.cc View 5 chunks +10 lines, -28 lines 0 comments Download
M src/heap/incremental-marking.h View 4 chunks +1 line, -22 lines 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
adamk
Created Revert of GC: Refactor public incremental marking interface in heap
5 years, 4 months ago (2015-08-04 17:47:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271823006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271823006/1
5 years, 4 months ago (2015-08-04 17:47:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 17:47:40 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0215fb56f4c75b054116632039edbff0d7f40373 Cr-Commit-Position: refs/heads/master@{#30011}
5 years, 4 months ago (2015-08-04 17:47:57 UTC) #4
Michael Lippautz
5 years, 4 months ago (2015-08-04 18:03:27 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698