Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1271803002: Add jpeg_skip_scanlines() API to libjpeg-turbo (Closed)

Created:
5 years, 4 months ago by msarett1
Modified:
5 years, 4 months ago
Reviewers:
agable, Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add jpeg_skip_scanlines() API to libjpeg-turbo jpeg_skip_scanlines() API, a subset decoding optimization aimed at Android, was submitted upstream r1582. Pull that change, and sundry fixes, into the Chromium repo. This new API is targetted at Android devices, not Chrome, and should have no affect on JPEG decode behavior or perf of Chrome. Chrome uses suspending data source JPEG decoding, and the new API does not support such sources. Adding support for suspending data sources is a future TODO, should the need arise (refer to skbug.com/4036). BUG=515694 BUG=468914 patch from issue 256280043 at patchset 50001 (http://crrev.com/256280043#ps50001) R=agable@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+/c9c8755c326b42c8d0dc938ec3f0d1d648bd361a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -4646 lines) Patch
M README.chromium View 3 chunks +13 lines, -9 lines 0 comments Download
M djpeg.c View 7 chunks +80 lines, -9 lines 0 comments Download
D google.patch View 1 chunk +0 lines, -4438 lines 0 comments Download
M jdapistd.c View 3 chunks +235 lines, -5 lines 0 comments Download
M jdarith.c View 4 chunks +8 lines, -4 lines 0 comments Download
A jdcoefct.h View 1 chunk +82 lines, -0 lines 0 comments Download
M jdcoefct.c View 3 chunks +2 lines, -72 lines 0 comments Download
M jdhuff.c View 4 chunks +10 lines, -7 lines 0 comments Download
A jdmainct.h View 1 chunk +71 lines, -0 lines 0 comments Download
M jdmainct.c View 3 chunks +1 line, -62 lines 0 comments Download
A jdsample.h View 1 chunk +50 lines, -0 lines 0 comments Download
M jdsample.c View 1 chunk +1 line, -40 lines 0 comments Download
M jpeglib.h View 2 chunks +3 lines, -0 lines 0 comments Download
M jpeglibmangler.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
agable
LGTM because Noel already gave LGTM on the prior issue on the other Rietveld instance.
5 years, 4 months ago (2015-08-03 16:17:07 UTC) #2
agable
Matt can't land this because this repo has no CQ and he is not yet ...
5 years, 4 months ago (2015-08-03 16:33:14 UTC) #3
agable
5 years, 4 months ago (2015-08-03 16:34:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9c8755c326b42c8d0dc938ec3f0d1d648bd361a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698