Create alternative service field trial group.

chrome/browser/io_thread_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/test/mock_entropy_provider.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
@@ skipping 79 matching lines @@
 }
 
 TEST_F(IOThreadTest, SpdyFieldTrialHoldbackEnabled) {
   net::HttpStreamFactory::set_spdy_enabled(true);
   field_trial_group_ = "SpdyDisabled";
   ConfigureSpdyGlobals();
   EXPECT_FALSE(net::HttpStreamFactory::spdy_enabled());
 }
 
 TEST_F(IOThreadTest, SpdyFieldTrialSpdy31Enabled) {
-  bool use_alternative_services = false;
   field_trial_group_ = "Spdy31Enabled";
   ConfigureSpdyGlobals();
   EXPECT_THAT(globals_.next_protos,
               ElementsAre(net::kProtoHTTP11,
                           net::kProtoSPDY31));
-  globals_.use_alternative_services.CopyToIfSet(&use_alternative_services);
-  EXPECT_TRUE(use_alternative_services);
 }
 
 TEST_F(IOThreadTest, SpdyFieldTrialSpdy4Enabled) {
-  bool use_alternative_services = false;
   field_trial_group_ = "Spdy4Enabled";
   ConfigureSpdyGlobals();
   EXPECT_THAT(
       globals_.next_protos,
       ElementsAre(net::kProtoHTTP11, net::kProtoSPDY31, net::kProtoHTTP2));
-  globals_.use_alternative_services.CopyToIfSet(&use_alternative_services);
-  EXPECT_TRUE(use_alternative_services);
 }
 
 TEST_F(IOThreadTest, SpdyFieldTrialDefault) {
   field_trial_group_ = "";
   ConfigureSpdyGlobals();
   EXPECT_THAT(
       globals_.next_protos,
       ElementsAre(net::kProtoHTTP11, net::kProtoSPDY31, net::kProtoHTTP2));
-  bool use_alternative_services = false;
-  globals_.use_alternative_services.CopyToIfSet(&use_alternative_services);
-  EXPECT_TRUE(use_alternative_services);
 }
 
 TEST_F(IOThreadTest, SpdyFieldTrialParametrized) {
   field_trial_params_["enable_spdy31"] = "false";
   // Undefined parameter "enable_http2_14" should default to false.
   field_trial_params_["enable_http2"] = "true";
   field_trial_group_ = "ParametrizedHTTP2Only";
   ConfigureSpdyGlobals();
   EXPECT_THAT(globals_.next_protos,
               ElementsAre(net::kProtoHTTP11, net::kProtoHTTP2));
-  bool use_alternative_services = false;
-  globals_.use_alternative_services.CopyToIfSet(&use_alternative_services);
-  EXPECT_TRUE(use_alternative_services);
 }
 
 TEST_F(IOThreadTest, SpdyCommandLineUseSpdyOff) {
   command_line_.AppendSwitchASCII("use-spdy", "off");
   // Command line should overwrite field trial group.
   field_trial_group_ = "Spdy4Enabled";
   ConfigureSpdyGlobals();
   EXPECT_EQ(0u, globals_.next_protos.size());
 }
 
+TEST_F(IOThreadTest, EnableAlternativeServicesFromFieldTrialParams) {

[Ryan Hamilton, 2015/08/27 17:24:18]

Can you move this down into the QUIC section, just to make it obvious that it's
QUIC specific? (And so that it's after the check on line 182 which verifies that
alt-svc is off by default for QUIC.

[Bence, 2015/08/27 17:29:54]

Done.

+  field_trial_group_ = "Enabled";
+  field_trial_params_["use_alternative_services"] = "true";
+
+  ConfigureQuicGlobals();
+  net::HttpNetworkSession::Params params;
+  InitializeNetworkSessionParams(&params);
+  EXPECT_TRUE(params.use_alternative_services);
+}
+
 TEST_F(IOThreadTest, DisableQuicByDefault) {
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_FALSE(params.enable_quic);
   EXPECT_FALSE(params.enable_quic_for_proxies);
   EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
 }
 
 TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
@@ skipping 11 matching lines @@
   EXPECT_EQ(default_params.quic_supported_versions,
             params.quic_supported_versions);
   EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options);
   EXPECT_FALSE(params.quic_always_require_handshake_confirmation);
   EXPECT_FALSE(params.quic_disable_connection_pooling);
   EXPECT_EQ(0.25f, params.quic_load_server_info_timeout_srtt_multiplier);
   EXPECT_FALSE(params.quic_enable_connection_racing);
   EXPECT_FALSE(params.quic_enable_non_blocking_io);
   EXPECT_FALSE(params.quic_disable_disk_cache);
   EXPECT_FALSE(params.quic_prefer_aes);
+  EXPECT_FALSE(params.use_alternative_services);
   EXPECT_EQ(0, params.quic_max_number_of_lossy_connections);
   EXPECT_EQ(1.0f, params.quic_packet_loss_threshold);
   EXPECT_FALSE(IOThread::ShouldEnableQuicForDataReductionProxy());
 }
 
 TEST_F(IOThreadTest, EnableQuicFromQuicProxyFieldTrialGroup) {
   base::FieldTrialList field_trial_list(new base::MockEntropyProvider());
   base::FieldTrialList::CreateFieldTrial(
       data_reduction_proxy::params::GetQuicFieldTrialName(), "Enabled");
 
@@ skipping 252 matching lines @@
   command_line_.AppendSwitch(switches::kEnableQuic);
   is_quic_allowed_by_policy_ = false;
   ConfigureQuicGlobals();
 
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_FALSE(params.enable_quic);
 }
 
 }  // namespace test