[2/3 chromium] Support redirect option of Request and "opaqueredirect" response type.

content/browser/loader/resource_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/resource_loader.h"
 
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/metrics/histogram.h"
 #include "base/profiler/scoped_tracker.h"
@@ skipping 262 matching lines @@
       !ChildProcessSecurityPolicyImpl::GetInstance()->
           CanRequestURL(info->GetChildID(), redirect_info.new_url)) {
     DVLOG(1) << "Denied unauthorized request for "
              << redirect_info.new_url.possibly_invalid_spec();
 
     // Tell the renderer that this request was disallowed.
     Cancel();
     return;
   }
 
+  if (info->fetch_redirect_mode() == FETCH_REDIRECT_MODE_ERROR) {
+    Cancel();
+    return;
+  } else if (info->fetch_redirect_mode() == FETCH_REDIRECT_MODE_MANUAL) {
+    // TODO(horo): If we will support upload progress events for Fetch API, we

[mmenke, 2015/08/11 16:06:14]

nit:  will -> "are going to"  (Or just remove "will").  "will" isn't generally
used with future conditionals.

[horo, 2015/08/11 16:43:55]

Done.

+    // will have to call ReportUploadProgress().
+    DCHECK(!GetRequestInfo()->is_upload_progress_enabled());
+
+    CompleteResponseStarted();
+    DCHECK(!is_deferred());

[mmenke, 2015/08/11 16:06:14]

Oh...I completely misunderstood this deferred stuff.  It's for side effects from
CompleteResponseStarted, not the initial state when this method is invoked.

Sorry about that.  Your old code was correct, but makes me nervous.  I want to
do some digging, and find out if there's a better way to do it than through a
magic state transition.

[horo, 2015/08/11 16:43:55]

I added is_redirect_response argument to CompleteResponseStarted.
What do you think about it?

+
+    // There is no need to read the response body here because there is no way
+    // to read the body of opaque-redirect filtered response's internal
+    // response.
+    // TODO(horo): If we will support any API which expose the internal body,

[mmenke, 2015/08/11 16:06:14]

nit:  will -> "are going to"  (Or just remove "will")

[horo, 2015/08/11 16:43:55]

Done.

+    // we will have to read the body before calling ResponseCompleted(). And
+    // also Cache changes will be needed because it doesn't store the body of
+    // redirect responses.
+    ResponseCompleted();
+    return;
+  }
+
   delegate_->DidReceiveRedirect(this, redirect_info.new_url);
 
   if (delegate_->HandleExternalProtocol(this, redirect_info.new_url)) {
     // The request is complete so we can remove it.
     CancelAndIgnore();
     return;
   }
 
   scoped_refptr<ResourceResponse> response(new ResourceResponse());
   PopulateResourceResponse(info, request_.get(), response.get());
@@ skipping 471 matching lines @@
       case net::URLRequestStatus::FAILED:
         status = STATUS_UNDEFINED;
         break;
     }
 
     UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX);
   }
 }
 
 }  // namespace content