[2/3 chromium] Support redirect option of Request and "opaqueredirect" response type.

content/browser/loader/resource_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/resource_loader.h"
 
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/metrics/histogram.h"
 #include "base/profiler/scoped_tracker.h"
@@ skipping 262 matching lines @@
       !ChildProcessSecurityPolicyImpl::GetInstance()->
           CanRequestURL(info->GetChildID(), redirect_info.new_url)) {
     DVLOG(1) << "Denied unauthorized request for "
              << redirect_info.new_url.possibly_invalid_spec();
 
     // Tell the renderer that this request was disallowed.
     Cancel();
     return;
   }
 
+  if (info->fetch_redirect_mode() == FETCH_REDIRECT_MODE_ERROR) {
+    Cancel();
+    return;
+  } else if (info->fetch_redirect_mode() == FETCH_REDIRECT_MODE_MANUAL) {
+    CompleteResponseStarted();

[yhirano, 2015/08/10 08:27:25]

You might want to notify the upload progress. (or TODO?)

[horo, 2015/08/10 08:57:10]

Done.
Added comment.

+    // We don't need to read the response body because there is no way to read
+    // the body of opaque-redirect filtered response's internal response.
+    // TODO(horo): When we will support any API which exposes the internal body,
+    // we have to read the body before calling ResponseCompleted().
+    ResponseCompleted();

[yhirano, 2015/08/10 08:27:26]

What happens when deferred?

[horo, 2015/08/10 08:57:10]

Who can set |defer|?
I think ResourceLoader::OnReceivedRedirect() is called directly from
URLRequest::NotifyReceivedRedirect() and which is called from
URLRequestJob::NotifyHeadersComplete().
So no one can set |defer|.

Is my understanding incorrect?

[yhirano, 2015/08/10 09:02:51]

|deferred_stage_| may be set in |CompleteResponseStarted|. I'm not sure what we
should do then.

[horo, 2015/08/10 09:42:29]

Ah, I see.
I think we should change deferred_stage_ to DEFERRED_RESPONSE_COMPLETE here not
to read the body.

+    return;
+  }
+
   delegate_->DidReceiveRedirect(this, redirect_info.new_url);
 
   if (delegate_->HandleExternalProtocol(this, redirect_info.new_url)) {
     // The request is complete so we can remove it.
     CancelAndIgnore();
     return;
   }
 
   scoped_refptr<ResourceResponse> response(new ResourceResponse());
   PopulateResourceResponse(info, request_.get(), response.get());
@@ skipping 471 matching lines @@
       case net::URLRequestStatus::FAILED:
         status = STATUS_UNDEFINED;
         break;
     }
 
     UMA_HISTOGRAM_ENUMERATION("Net.Prefetch.Pattern", status, STATUS_MAX);
   }
 }
 
 }  // namespace content