Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/compiler/move-optimizer.cc

Issue 1271703002: [turbofan] Stand-alone deferred block splitting - full. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/move-optimizer.cc
diff --git a/src/compiler/move-optimizer.cc b/src/compiler/move-optimizer.cc
index b869185e60ed2aed9dbc939878d1874e92e4eda6..7c2bbe06b874005e74b3260fbcb8275e28df9978 100644
--- a/src/compiler/move-optimizer.cc
+++ b/src/compiler/move-optimizer.cc
@@ -59,6 +59,17 @@ void MoveOptimizer::Run() {
}
for (auto block : code()->instruction_blocks()) {
if (block->PredecessorCount() <= 1) continue;
+ bool has_only_deferred = true;
+ for (RpoNumber pred_id : block->predecessors()) {
+ if (!code()->InstructionBlockAt(pred_id)->IsDeferred()) {
+ has_only_deferred = false;
+ break;
+ }
+ }
+ // This would pull down common moves. If the moves occur in deferred blocks,
+ // and the closest common successor is not deferred, we lose the
+ // optimization of just spilling/filling in deferred blocks.
+ if (has_only_deferred) continue;
OptimizeMerge(block);
}
for (auto gap : to_finalize_) {
« no previous file with comments | « src/compiler/instruction.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698