[turbofan] Stand-alone deferred block splitting - full.

src/compiler/move-optimizer.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/move-optimizer.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
@@ skipping 41 matching lines @@
       temp_vector_0_(local_zone),
       temp_vector_1_(local_zone) {}
 
 
 void MoveOptimizer::Run() {
   for (auto* block : code()->instruction_blocks()) {
     CompressBlock(block);
   }
   for (auto block : code()->instruction_blocks()) {
     if (block->PredecessorCount() <= 1) continue;
+    bool has_only_deferred = true;
+    for (RpoNumber pred_id : block->predecessors()) {
+      if (!code()->InstructionBlockAt(pred_id)->IsDeferred()) {
+        has_only_deferred = false;
+        break;
+      }
+    }
+    if (has_only_deferred) continue;

[Jarin, 2015/08/04 19:39:43]

Could you explain why we skip the optimization here?

[Mircea Trofin, 2015/08/04 20:34:46]

This would pull down common fills. If the fills occur in deferred blocks, and
the closest common successor is not deferred, we lose the optimization of
spilling/filling just in deferred blocks.

[Mircea Trofin, 2015/08/04 20:39:04]

Should have added: the last statement of the MultipleDeferredBlockSpills unit
test (EXPECT_EQ...) would fail without this logic.

     OptimizeMerge(block);
   }
   for (auto gap : to_finalize_) {
     FinalizeMoves(gap);
   }
 }
 
 
 void MoveOptimizer::CompressMoves(MoveOpVector* eliminated, ParallelMove* left,
                                   ParallelMove* right) {
@@ skipping 204 matching lines @@
         static_cast<Instruction::GapPosition>(1), code_zone());
     slot_1->AddMove(group_begin->destination(), load->destination());
     load->Eliminate();
   }
   loads.clear();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8