Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: sync/protocol/synced_notification_data.proto

Issue 12717010: Widen Data Pipes and newer protobufs (Closed) Base URL: http://git.chromium.org/chromium/src.git@newProtobufs
Patch Set: Synced Notifications newer protobufs - improve unit test robustness Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/synced_notification_data.proto
diff --git a/sync/protocol/synced_notification_data.proto b/sync/protocol/synced_notification_data.proto
index fed7ee7d90898d81248b55520cbfd1978556bbcb..37fb59f50659c71b477e78fa46eb00ed22aa9738 100644
--- a/sync/protocol/synced_notification_data.proto
+++ b/sync/protocol/synced_notification_data.proto
@@ -63,8 +63,8 @@ message SyncedNotification {
// The creator of the notification.
optional SyncedNotificationCreator creator = 3;
- // TODO(petewil): This won't build. Import the relevant protobuf.
- // optional MapData client_data = 4;
+ // Client specific data.
+ optional MapData client_data = 4;
}
message CoalescedSyncedNotification {
@@ -103,4 +103,25 @@ message CoalescedSyncedNotification {
message SyncedNotificationList {
repeated CoalescedSyncedNotification coalesced_notification = 1;
-}
+}
+
+message MapData {
Nicolas Zea 2013/03/28 17:43:41 Could you comment what this, MapData, and ListData
Pete Williamson 2013/03/28 19:59:00 Done.
+ message Entry {
+ optional string key = 1;
+ optional Data value = 2;
+ };
+ repeated Entry entry = 1;
+};
+
+message Data {
+ optional bool boolean_value = 1;
+ optional int32 int_value = 2;
+ optional double float_value = 3;
+ optional string string_value = 4;
+ optional ListData list_value = 5;
+ optional MapData map_value = 6;
+};
+
+message ListData {
+ repeated Data value = 1;
+};

Powered by Google App Engine
This is Rietveld 408576698