Widen Data Pipes and newer protobufs

sync/protocol/synced_notification_data.proto

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol datatype extension for push notifications..
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
@@ skipping 45 matching lines @@
   optional string type = 1;
 
   // Whatever string the client entered during creation.  If no external_id is
   // specified, the notification can no longer be identified individually for
   // fetching/deleting, etc...
   optional string external_id = 2;
 
   // The creator of the notification.
   optional SyncedNotificationCreator creator = 3;
 
-  // TODO(petewil): This won't build.  Import the relevant protobuf.
-  // optional MapData client_data = 4;
+  // Client specific data.
+  optional MapData client_data = 4;
 }
 
 message CoalescedSyncedNotification {
   // An opaque string key used to identify individual coalesced notifications.
   optional string key = 1;
 
   optional string app_id = 2;
 
   // All the notifications that are grouped together.
   repeated SyncedNotification notification = 3;
@@ skipping 18 matching lines @@
     LOW = 1;
     STANDARD = 2;
     HIGH = 3;
     // We will most likely add at least one more priority in the near future.
   };
   optional Priority priority = 7;
 }
 
 message SyncedNotificationList {
   repeated CoalescedSyncedNotification coalesced_notification = 1;
-}
+}
+
+message MapData {

[Nicolas Zea, 2013/03/28 17:43:41]

Could you comment what this, MapData, and ListData are for?

[Pete Williamson, 2013/03/28 19:59:00]

Done.

+  message Entry {
+    optional string key = 1;
+    optional Data value = 2;
+  };
+  repeated Entry entry = 1;
+};
+
+message Data {
+  optional bool boolean_value = 1;
+  optional int32 int_value = 2;
+  optional double float_value = 3;
+  optional string string_value = 4;
+  optional ListData list_value = 5;
+  optional MapData map_value = 6;
+};
+
+message ListData {
+  repeated Data value = 1;
+};