Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 12717002: Make GPU cache size cmd line configurable in GM. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make GPU cache size cmd line configurable in GM. Committed: https://code.google.com/p/skia/source/detail?r=8076

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M gm/gmmain.cpp View 1 2 8 chunks +34 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
7 years, 9 months ago (2013-03-08 19:40:14 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/12717002/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/12717002/diff/1/gm/gmmain.cpp#newcode1036 gm/gmmain.cpp:1036: #if SK_SUPPORT_GPU 0 for both will ...
7 years, 9 months ago (2013-03-08 19:51:51 UTC) #2
robertphillips
Also (as separate CLs) do we want to propagate this to bench, bench_pictures and SampleApp?
7 years, 9 months ago (2013-03-08 19:52:51 UTC) #3
bsalomon
Yes, I think we want to do the others. https://codereview.chromium.org/12717002/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/12717002/diff/1/gm/gmmain.cpp#newcode1269 gm/gmmain.cpp:1269: ...
7 years, 9 months ago (2013-03-08 20:00:12 UTC) #4
bsalomon
https://codereview.chromium.org/12717002/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/12717002/diff/1/gm/gmmain.cpp#newcode1036 gm/gmmain.cpp:1036: #if SK_SUPPORT_GPU On 2013/03/08 19:51:51, robertphillips wrote: > 0 ...
7 years, 9 months ago (2013-03-08 20:01:05 UTC) #5
bsalomon
7 years, 9 months ago (2013-03-11 20:22:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r8076 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698