Don't show the group notification when there is only one in-progress download

chrome/browser/download/notification/download_notification_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
@@ skipping 766 matching lines @@
   // Confirms the types of download notifications are correct.
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id1)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id2)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_MULTIPLE,
             GetNotification(notification_id_group)->type());
   EXPECT_EQ(2u, GetNotification(notification_id_group)->items().size());
 }
 
+IN_PROC_BROWSER_TEST_F(DownloadNotificationTest,
+                       DownloadMultipleFilesOneByOne) {
+  CreateDownload();

[asanka, 2015/08/04 21:55:09]

I think the fact that this call changes global state for the test fixture makes
it a bit hard to read these tests. We should clean this up a bit.

For example, the notification(), download_item() etc. calls are referring to the
download and notifications created here. And then the test has to manually
create a second set of values by manually initiating a download. It would be
great if there was a single CreateDownload() call that is reusable.

[yoshiki, 2015/08/05 09:09:31]

I added some comments, and introduced variables for each downloads instead of
using the methods in the class.

+
+  // Requests to complete the download.
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(net::URLRequestSlowDownloadJob::kFinishDownloadUrl));
+
+  // Waits for download completion.
+  while (download_item()->GetState() != content::DownloadItem::COMPLETE) {
+    NotificationUpdateObserver download_change_notification_observer;
+    download_change_notification_observer.Wait();
+  }
+  EXPECT_EQ(content::DownloadItem::COMPLETE, download_item()->GetState());
+
+  // Opens the message center.
+  EXPECT_EQ(1u, GetMessageCenter()->GetVisibleNotifications().size());
+
+  // Starts another download.
+  GURL url(net::URLRequestSlowDownloadJob::kKnownSizeUrl);
+  NotificationAddObserver download_start_notification_observer;
+  ui_test_utils::NavigateToURL(browser(), url);
+  EXPECT_TRUE(download_start_notification_observer.Wait());
+
+  // Confirms that a notification is created.
+  std::string second_notification_id =
+      download_start_notification_observer.notification_id();
+  EXPECT_FALSE(second_notification_id.empty());
+  ASSERT_TRUE(notification());
+
+  // Confirms that there is two notification.

[asanka, 2015/08/04 21:55:09]

.. are two notifications...

[yoshiki, 2015/08/05 09:09:31]

Done.

+  message_center::NotificationList::Notifications
+      visible_notifications = GetMessageCenter()->GetVisibleNotifications();
+  EXPECT_EQ(2u, visible_notifications.size());
+  EXPECT_TRUE(IsInNotifications(visible_notifications, second_notification_id));
+
+  // Confirms that a download is also started.
+  std::vector<content::DownloadItem*> downloads;
+  GetDownloadManager(browser())->GetAllDownloads(&downloads);
+  EXPECT_EQ(2u, downloads.size());
+  EXPECT_TRUE(download_item() == downloads[0] ||
+              download_item() == downloads[1]);
+  content::DownloadItem* second_download_item;
+  if (download_item() == downloads[0])
+    second_download_item = downloads[1];
+  else
+    second_download_item = downloads[0];
+
+  EXPECT_EQ(content::DownloadItem::IN_PROGRESS,
+            second_download_item->GetState());
+
+  // Requests to complete the download.
+  ui_test_utils::NavigateToURL(
+      browser(), GURL(net::URLRequestSlowDownloadJob::kFinishDownloadUrl));
+
+  // Waits for download completion.
+  while (second_download_item->GetState() != content::DownloadItem::COMPLETE) {
+    NotificationUpdateObserver download_change_notification_observer;
+    download_change_notification_observer.Wait();
+  }
+
+  // Opens the message center.
+  GetMessageCenter()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
+  EXPECT_EQ(2u, GetMessageCenter()->GetVisibleNotifications().size());
+  EXPECT_EQ(content::DownloadItem::COMPLETE, second_download_item->GetState());
+}
+
 IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, CancelDownload) {
   CreateDownload();
 
   // Opens the message center.
   GetMessageCenter()->SetVisibility(message_center::VISIBILITY_MESSAGE_CENTER);
 
   // Cancels the notification by clicking the "cancel' button.
   NotificationRemoveObserver notification_close_observer;
   notification()->ButtonClick(1);
   EXPECT_EQ(notification_id(), notification_close_observer.Wait());
@@ skipping 333 matching lines @@
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_MULTIPLE,
             GetNotification(notification_id_user2_group)->type());
   EXPECT_EQ(2u,
             GetNotification(notification_id_user2_group)->items().size());
   // Normal notifications for user2.
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id_user2_1)->type());
   EXPECT_EQ(message_center::NOTIFICATION_TYPE_BASE_FORMAT,
             GetNotification(notification_id_user2_2)->type());
 }