Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 12716011: Hotfix the build on the ChromeOS ASan bots: only add a dependency on ASan dynamic runtime for OS X … (Closed)

Created:
7 years, 9 months ago by Alexander Potapenko
Modified:
7 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Hotfix the build on the ChromeOS ASan bots: only add a dependency on ASan dynamic runtime for OS X and iOS. BUG=170629 TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187582

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
TBR Apparently the lack of real ChromiumOS trybots prevented us from catching this earlier.
7 years, 9 months ago (2013-03-12 13:47:26 UTC) #1
Mark Mentovai
LGTM
7 years, 9 months ago (2013-03-12 13:49:45 UTC) #2
Alexander Potapenko
7 years, 9 months ago (2013-03-12 14:06:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r187582 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698