Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: test/cctest/test-serialize.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed rest Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index b07db0f527dc092d9b54e67d4f20ce3ca462b0fb..777c769b24914f58d8b9417b306b6d72e59522c4 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -282,7 +282,7 @@ static void Deserialize() {
static void SanityCheck() {
- v8::HandleScope scope;
+ v8::HandleScope scope(v8::Isolate::GetCurrent());
#ifdef VERIFY_HEAP
HEAP->Verify();
#endif
@@ -299,7 +299,7 @@ DEPENDENT_TEST(Deserialize, Serialize) {
// serialization. That doesn't matter. We don't need to be able to
// serialize a snapshot in a VM that is booted from a snapshot.
if (!Snapshot::HaveASnapshotToStartFrom()) {
- v8::HandleScope scope;
+ v8::HandleScope scope(v8::Isolate::GetCurrent());
Deserialize();
v8::Persistent<v8::Context> env = v8::Context::New();
@@ -312,7 +312,7 @@ DEPENDENT_TEST(Deserialize, Serialize) {
DEPENDENT_TEST(DeserializeFromSecondSerialization, SerializeTwice) {
if (!Snapshot::HaveASnapshotToStartFrom()) {
- v8::HandleScope scope;
+ v8::HandleScope scope(v8::Isolate::GetCurrent());
Deserialize();
v8::Persistent<v8::Context> env = v8::Context::New();
@@ -325,7 +325,7 @@ DEPENDENT_TEST(DeserializeFromSecondSerialization, SerializeTwice) {
DEPENDENT_TEST(DeserializeAndRunScript2, Serialize) {
if (!Snapshot::HaveASnapshotToStartFrom()) {
- v8::HandleScope scope;
+ v8::HandleScope scope(v8::Isolate::GetCurrent());
Deserialize();
v8::Persistent<v8::Context> env = v8::Context::New();
@@ -342,7 +342,7 @@ DEPENDENT_TEST(DeserializeAndRunScript2, Serialize) {
DEPENDENT_TEST(DeserializeFromSecondSerializationAndRunScript2,
SerializeTwice) {
if (!Snapshot::HaveASnapshotToStartFrom()) {
- v8::HandleScope scope;
+ v8::HandleScope scope(v8::Isolate::GetCurrent());
Deserialize();
v8::Persistent<v8::Context> env = v8::Context::New();
@@ -377,7 +377,7 @@ TEST(PartialSerialization) {
Object* raw_foo;
{
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(env->GetIsolate());
v8::Local<v8::String> foo = v8::String::New("foo");
ASSERT(!foo.IsEmpty());
raw_foo = *(v8::Utils::OpenHandle(*foo));
@@ -473,7 +473,7 @@ DEPENDENT_TEST(PartialDeserialization, PartialSerialization) {
deserializer.DeserializePartial(&root);
CHECK(root->IsString());
}
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
Handle<Object> root_handle(root, Isolate::Current());
@@ -571,7 +571,7 @@ DEPENDENT_TEST(ContextDeserialization, ContextSerialization) {
deserializer.DeserializePartial(&root);
CHECK(root->IsContext());
}
- v8::HandleScope handle_scope;
+ v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
Handle<Object> root_handle(root, Isolate::Current());

Powered by Google App Engine
This is Rietveld 408576698