Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: test/cctest/test-assembler-x64.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed rest Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-assembler-x64.cc
diff --git a/test/cctest/test-assembler-x64.cc b/test/cctest/test-assembler-x64.cc
index af06b013aa3939fdb7100c16357aa4f7f4a0054e..d2ea771588c9ec7313cd41e9b5dba75a49ee44bb 100644
--- a/test/cctest/test-assembler-x64.cc
+++ b/test/cctest/test-assembler-x64.cc
@@ -361,7 +361,8 @@ TEST(OperandRegisterDependency) {
TEST(AssemblerX64LabelChaining) {
// Test chaining of label usages within instructions (issue 1644).
- v8::HandleScope scope;
+ InitializeVM();
+ v8::HandleScope scope(env->GetIsolate());
Assembler assm(Isolate::Current(), NULL, 0);
Label target;
@@ -374,7 +375,7 @@ TEST(AssemblerX64LabelChaining) {
TEST(AssemblerMultiByteNop) {
InitializeVM();
- v8::HandleScope scope;
+ v8::HandleScope scope(env->GetIsolate());
v8::internal::byte buffer[1024];
Isolate* isolate = Isolate::Current();
Assembler assm(isolate, buffer, sizeof(buffer));

Powered by Google App Engine
This is Rietveld 408576698