Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/d8-posix.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed rest Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/d8-posix.cc
diff --git a/src/d8-posix.cc b/src/d8-posix.cc
index 8a278e4e42edfc2d8443e170caa93b7bc3aaf515..1be782a241de2266283efc5f8eb61b3e686529db 100644
--- a/src/d8-posix.cc
+++ b/src/d8-posix.cc
@@ -449,7 +449,7 @@ static bool WaitForChild(int pid,
// Implementation of the system() function (see d8.h for details).
Handle<Value> Shell::System(const Arguments& args) {
- HandleScope scope;
+ HandleScope scope(args.GetIsolate());
int read_timeout = -1;
int total_timeout = -1;
if (!GetTimeouts(args, &read_timeout, &total_timeout)) return v8::Undefined();

Powered by Google App Engine
This is Rietveld 408576698