Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: src/d8-debug.h

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed rest Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/d8-debug.h
diff --git a/src/d8-debug.h b/src/d8-debug.h
index aeff3c121c1b71244352d05fdc271327dbcb4283..a6cea2a81bdb7a007fcac73ef16ffcb8084ff4eb 100644
--- a/src/d8-debug.h
+++ b/src/d8-debug.h
@@ -43,7 +43,7 @@ void HandleDebugEvent(DebugEvent event,
// Start the remove debugger connecting to a V8 debugger agent on the specified
// port.
-void RunRemoteDebugger(int port);
+void RunRemoteDebugger(Isolate* isolate, int port);
// Forward declerations.
class RemoteDebuggerEvent;
@@ -53,8 +53,9 @@ class ReceiverThread;
// Remote debugging class.
class RemoteDebugger {
public:
- explicit RemoteDebugger(int port)
- : port_(port),
+ explicit RemoteDebugger(Isolate* isolate, int port)
+ : isolate_(isolate),
+ port_(port),
event_access_(i::OS::CreateMutex()),
event_available_(i::OS::CreateSemaphore(0)),
head_(NULL), tail_(NULL) {}
@@ -79,6 +80,7 @@ class RemoteDebugger {
// Get connection to agent in debugged V8.
i::Socket* conn() { return conn_; }
+ Isolate* isolate_;
int port_; // Port used to connect to debugger V8.
i::Socket* conn_; // Connection to debugger agent in debugged V8.

Powered by Google App Engine
This is Rietveld 408576698