Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: test/cctest/test-global-object.cc

Issue 12716010: Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Feedback. Rebased Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-func-name-inference.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 16 matching lines...) Expand all
27 27
28 #include "v8.h" 28 #include "v8.h"
29 29
30 #include "cctest.h" 30 #include "cctest.h"
31 31
32 using namespace v8; 32 using namespace v8;
33 33
34 // This test fails if properties on the prototype of the global object appear 34 // This test fails if properties on the prototype of the global object appear
35 // as declared globals. 35 // as declared globals.
36 TEST(StrictUndeclaredGlobalVariable) { 36 TEST(StrictUndeclaredGlobalVariable) {
37 HandleScope scope; 37 HandleScope scope(Isolate::GetCurrent());
38 v8::Local<v8::String> var_name = v8_str("x"); 38 v8::Local<v8::String> var_name = v8_str("x");
39 LocalContext context; 39 LocalContext context;
40 v8::TryCatch try_catch; 40 v8::TryCatch try_catch;
41 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;"); 41 v8::Local<v8::Script> script = v8_compile("\"use strict\"; x = 42;");
42 v8::Handle<v8::Object> proto = v8::Object::New(); 42 v8::Handle<v8::Object> proto = v8::Object::New();
43 v8::Handle<v8::Object> global = 43 v8::Handle<v8::Object> global =
44 context->Global()->GetPrototype().As<v8::Object>(); 44 context->Global()->GetPrototype().As<v8::Object>();
45 proto->Set(var_name, v8_num(100)); 45 proto->Set(var_name, v8_num(100));
46 global->SetPrototype(proto); 46 global->SetPrototype(proto);
47 script->Run(); 47 script->Run();
48 CHECK(try_catch.HasCaught()); 48 CHECK(try_catch.HasCaught());
49 v8::String::Utf8Value exception(try_catch.Exception()); 49 v8::String::Utf8Value exception(try_catch.Exception());
50 CHECK_EQ("ReferenceError: x is not defined", *exception); 50 CHECK_EQ("ReferenceError: x is not defined", *exception);
51 } 51 }
OLDNEW
« no previous file with comments | « test/cctest/test-func-name-inference.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698