Fix cancellation of a pair of URLRequestJob subclasses

net/url_request/url_request_simple_job_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/worker_pool.h"
@@ skipping 47 matching lines @@
  private:
   ~MockSimpleJob() override {}
 
   const std::string data_;
 
   scoped_refptr<base::TaskRunner> task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(MockSimpleJob);
 };
 
-class CancelURLRequestDelegate : public URLRequest::Delegate {
+class CancelURLRequestDelegate : public TestDelegate {

[davidben, 2015/08/05 18:56:39]

Any reason this CancelURLRequestDelegate calls Read itself while the
url_data_manager_backend_unittest leans on TestDelegate?

[mmenke, 2015/08/05 20:00:24]

Carelessness on my part, while iterating to get the two tests to fail a bit
better on regression.  I've made them identical, except the RunLoop (It's not
strictly needed in the other test, but given the thread hopping there, I'm
happier having it.

  public:
   CancelURLRequestDelegate()
       : buf_(new IOBuffer(kBufferSize)), run_loop_(new base::RunLoop) {}
 
   void OnResponseStarted(URLRequest* request) override {
     int bytes_read = 0;
     EXPECT_FALSE(request->Read(buf_.get(), kBufferSize, &bytes_read));
     EXPECT_TRUE(request->status().is_io_pending());
     request->Cancel();
     run_loop_->Quit();
   }
 
-  void OnReadCompleted(URLRequest* request, int bytes_read) override {}
+  void OnReadCompleted(URLRequest* request, int bytes_read) override {
+    // Read should have been cancelled.
+    EXPECT_EQ(-1, bytes_read);
+  }
 
   void WaitUntilHeadersReceived() const { run_loop_->Run(); }
 
  private:
   static const int kBufferSize = 4096;
   scoped_refptr<IOBuffer> buf_;
   scoped_ptr<base::RunLoop> run_loop_;
 };
 
 class SimpleJobProtocolHandler :
@@ skipping 109 matching lines @@
 }
 
 TEST_F(URLRequestSimpleJobTest, EmptyDataRequest) {
   request_ =
       context_.CreateRequest(GURL("data:empty"), DEFAULT_PRIORITY, &delegate_);
   StartRequest(nullptr);
   ASSERT_TRUE(request_->status().is_success());
   EXPECT_EQ("", delegate_.data_received());
 }
 
-TEST_F(URLRequestSimpleJobTest, CancelAfterFirstRead) {
+TEST_F(URLRequestSimpleJobTest, CancelBeforeResponseStarts) {
+  request_ =
+      context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY, &delegate_);
+  request_->Start();
+  request_->Cancel();
+
+  base::RunLoop().RunUntilIdle();
+  EXPECT_EQ(URLRequestStatus::CANCELED, request_->status().status());
+  EXPECT_EQ(1, delegate_.response_started_count());
+}
+
+TEST_F(URLRequestSimpleJobTest, CancelAfterFirstReadStarted) {
   scoped_ptr<CancelURLRequestDelegate> cancel_delegate(
       new CancelURLRequestDelegate());
   request_ = context_.CreateRequest(GURL("data:cancel"), DEFAULT_PRIORITY,
                                     cancel_delegate.get());
   request_->Start();
   cancel_delegate->WaitUntilHeadersReceived();
 
   // Feed a dummy task to the SequencedTaskRunner to make sure that the
   // callbacks which are invoked in ReadRawData have completed safely.
   base::RunLoop run_loop;
   EXPECT_TRUE(task_runner_->PostTaskAndReply(
       FROM_HERE, base::Bind(&base::DoNothing), run_loop.QuitClosure()));
   run_loop.Run();
+
+  EXPECT_EQ(URLRequestStatus::CANCELED, request_->status().status());
 }
 
 }  // namespace net