Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1271583002: PPC: Clean up register save/restore logic. (Closed)

Created:
5 years, 4 months ago by MTBrandyberry
Modified:
5 years, 4 months ago
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Clean up register save/restore logic. NOPRESUBMIT=true R=titzer@chromium.org, michael_dawson@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com BUG= Committed: https://crrev.com/e16cfe562d5dc142eb604002afb3d0e4dfca663e Cr-Commit-Position: refs/heads/master@{#29978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -76 lines) Patch
M src/compiler/c-linkage.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +21 lines, -12 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 4 chunks +12 lines, -17 lines 0 comments Download
M src/ppc/frames-ppc.h View 1 chunk +37 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 2 chunks +5 lines, -8 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 4 chunks +39 lines, -32 lines 0 comments Download
M src/ppc/regexp-macro-assembler-ppc.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (5 generated)
MTBrandyberry
Including titzer due to the change to src/compiler/c-linkage.cc.
5 years, 4 months ago (2015-07-31 18:55:02 UTC) #1
JoranSiu
lgtm
5 years, 4 months ago (2015-07-31 19:31:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271583002/1
5 years, 4 months ago (2015-07-31 19:35:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4609)
5 years, 4 months ago (2015-07-31 19:38:10 UTC) #6
john.yan
lgtm
5 years, 4 months ago (2015-07-31 20:29:18 UTC) #7
MTBrandyberry
On 2015/07/31 20:29:18, john.yan wrote: > lgtm Still need approval from src/compiler owner @titzer.
5 years, 4 months ago (2015-08-03 13:24:01 UTC) #8
titzer
lgtm
5 years, 4 months ago (2015-08-03 13:25:20 UTC) #9
MTBrandyberry
On 2015/08/03 13:25:20, titzer wrote: > lgtm Thank you!
5 years, 4 months ago (2015-08-03 13:25:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271583002/1
5 years, 4 months ago (2015-08-03 13:26:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4636)
5 years, 4 months ago (2015-08-03 13:28:59 UTC) #14
MTBrandyberry
On 2015/08/03 13:28:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 4 months ago (2015-08-03 13:33:48 UTC) #15
titzer
On 2015/08/03 13:33:48, mtbrandyberry wrote: > On 2015/08/03 13:28:59, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-08-03 13:55:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271583002/1
5 years, 4 months ago (2015-08-03 14:36:37 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 14:36:47 UTC) #19
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 14:37:03 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e16cfe562d5dc142eb604002afb3d0e4dfca663e
Cr-Commit-Position: refs/heads/master@{#29978}

Powered by Google App Engine
This is Rietveld 408576698