Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1271533002: Make SkIsPow2 templated (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : don't rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M include/core/SkMath.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
Factoring this out of a larger CL
5 years, 4 months ago (2015-07-31 14:37:25 UTC) #2
bsalomon
just template, don't rename
5 years, 4 months ago (2015-07-31 15:08:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271533002/20001
5 years, 4 months ago (2015-07-31 15:09:19 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-07-31 15:09:20 UTC) #6
reed1
lgtm
5 years, 4 months ago (2015-07-31 15:21:53 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 15:22:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1421aee64afa1bfbeb36c0550caf311898e8ba2b

Powered by Google App Engine
This is Rietveld 408576698