Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1271523003: Remove remoting client plugin from chrome. (Closed)

Created:
5 years, 4 months ago by Sergey Ulanov
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove remoting client plugin from chrome. CRD app now bundles PNaCl version of the plugin so it doesn't need to be built in chrome anymore. BUG=510271 Committed: https://crrev.com/ca4bd001980cbcf427fb84cbb85a23491ab94996 Cr-Commit-Position: refs/heads/master@{#341804}

Patch Set 1 #

Patch Set 2 : Fix android and GN build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -248 lines) Patch
M chrome/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 3 chunks +0 lines, -61 lines 0 comments Download
M chrome/plugin/chrome_content_plugin_client.cc View 2 chunks +0 lines, -32 lines 0 comments Download
M pdf/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 1 1 chunk +1 line, -7 lines 0 comments Download
D remoting/client/plugin/pepper_entrypoints.h View 1 chunk +0 lines, -21 lines 0 comments Download
D remoting/client/plugin/pepper_entrypoints.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M remoting/remoting_all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/remoting_client.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Sergey Ulanov
5 years, 4 months ago (2015-07-31 17:17:51 UTC) #2
sky
sky->brettw
5 years, 4 months ago (2015-08-03 15:36:18 UTC) #4
brettw
I don't know what CRD is so the larger-concept is obscure to me. But: Yay ...
5 years, 4 months ago (2015-08-03 23:52:01 UTC) #5
Sergey Ulanov
On 2015/08/03 23:52:01, brettw wrote: > I don't know what CRD is so the larger-concept ...
5 years, 4 months ago (2015-08-04 15:55:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271523003/1
5 years, 4 months ago (2015-08-04 15:57:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/103175) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-04 16:06:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271523003/20001
5 years, 4 months ago (2015-08-04 18:50:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/88375)
5 years, 4 months ago (2015-08-04 20:19:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271523003/20001
5 years, 4 months ago (2015-08-04 20:38:44 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-04 21:33:02 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 21:35:33 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca4bd001980cbcf427fb84cbb85a23491ab94996
Cr-Commit-Position: refs/heads/master@{#341804}

Powered by Google App Engine
This is Rietveld 408576698