LayoutTests/fast/multicol/span/add-spanner-inside-overflow-hidden.html - Issue 1271513004: Disallow relayout roots inside multicol.

Side by Side Diff: LayoutTests/fast/multicol/span/add-spanner-inside-overflow-hidden.html

Issue 1271513004: Disallow relayout roots inside multicol. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>Add a spanner inside a fixed-size clipped block inside a multicol container. It should not be

	3 affected by the clipping, since the containing block of a spanner is the mul ticol

	4 container. This also tests that we don't perform any optimized subtree layou t operations

	5 incompatible with multicol (which would typically cause assertion failures). </p>

	6 <p>You should see the word "PASS" below, and nothing else (no red, no "FAIL").</ p>

	7 <div style="-webkit-columns:2; width:20em; height:10em; line-height:2em; overflo w:hidden;">
	Julien - ping for review 2015/08/03 16:47:59 Do we really need both this overflow: hidden and t Do we really need both this overflow: hidden and the one just below? Same question with width? mstensho (USE GERRIT) 2015/08/04 12:06:07 When inserting a spanner, we insert a spanner plac Show quoted text On 2015/08/03 16:47:59, Julien Chaffraix - PST wrote: > Do we really need both this overflow: hidden and the one just below? Same > question with width? When inserting a spanner, we insert a spanner placeholder as a child of the multicol container. This will mark the multicol container for layout. If we had no relayout root here, we'd end up marking the ancestry chain all the way up to LayoutView, and when the LayoutView is marked for layout, we remove any subtree roots that were previously marked for layout (clearLayoutSubtreeRootsAndMarkContainingBlocks()), and prevent subtree roots from being added, until we have laid out. But sure there are ways to trigger this without two overflow:hiddens. Added a couple of more tests. One even failed in assertLaidOut()! I put everything in fast/multicol/dynamic/ instead of in fast/multicol/span/ . This is not so much about spanners; it's just that spanners are useful here to cause general misery in the multicol code (I wasn't able to think of any way to cause trouble without using spanners, but it might have been possible). Julien - ping for review 2015/08/05 16:34:26 That's reasonable, I was just trying to make sure Show quoted text On 2015/08/04 at 12:06:07, mstensho wrote: > On 2015/08/03 16:47:59, Julien Chaffraix - PST wrote: > > Do we really need both this overflow: hidden and the one just below? Same > > question with width? > > When inserting a spanner, we insert a spanner placeholder as a child of the multicol container. This will mark the multicol container for layout. If we had no relayout root here, we'd end up marking the ancestry chain all the way up to LayoutView, and when the LayoutView is marked for layout, we remove any subtree roots that were previously marked for layout (clearLayoutSubtreeRootsAndMarkContainingBlocks()), and prevent subtree roots from being added, until we have laid out. > > But sure there are ways to trigger this without two overflow:hiddens. Added a couple of more tests. One even failed in assertLaidOut()! I put everything in fast/multicol/dynamic/ instead of in fast/multicol/span/ . This is not so much about spanners; it's just that spanners are useful here to cause general misery in the multicol code (I wasn't able to think of any way to cause trouble without using spanners, but it might have been possible). That's reasonable, I was just trying to make sure we had reduced the test cases and got carried away (forgot we needed at least some relayout root with width / height).
	8 <div style="width:5em; height:2em; overflow:hidden;">

	9

	10 <div id="spanner" style="-webkit-column-span:all; display:none;">PASS</d iv>

	11 <span style="background:red;">FAIL</span>

	12 </div>

	13 </div>

	14 <script>

	15 document.body.offsetTop;

	16 document.getElementById("spanner").style.display = "block";

	17 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/span/add-spanner-inside-overflow-hidden-expected.html » ('j') | no next file with comments »