Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1271443002: Revert of Upon load failure, remove sync script from execution queue. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Upon load failure, remove sync script from execution queue. (patchset #3 id:40001 of https://codereview.chromium.org/1263743002/) Reason for revert: Speculatively reverting to see if it addresses the recent crashes being reported via http://crbug.com/515419 Original issue's description: > Upon load failure, remove sync script from execution queue. > > If a script element is to be loaded synchronously and executed in order, > it's queued for execution before loading. Should that load fail, the > immediate execution of the script, > > https://html.spec.whatwg.org/#execute-the-script-block > > should only result in an error event being dispatched. > > Implementation-wise, along with signalling error, the failed script must also > be removed from the internal in-order execution queue. We're done with > (not) executing the script and failure to remove it will cause subsequent > processing of the script execution queue to see the script as having failed > to load and re-dispatch an error event. > > R=haraken > BUG=503077 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199656 TBR=haraken@chromium.org,tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=503077 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -64 lines) Patch
D LayoutTests/fast/dom/HTMLScriptElement/script-sync-onerror-not-repeated.html View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/script-sync-onerror-not-repeated-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/ScriptRunner.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Upon load failure, remove sync script from execution queue.
5 years, 4 months ago (2015-07-31 05:31:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271443002/1
5 years, 4 months ago (2015-07-31 05:31:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199788
5 years, 4 months ago (2015-07-31 05:32:09 UTC) #3
haraken
5 years, 4 months ago (2015-07-31 06:10:28 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698