Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1271433002: X87: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. port c5dd553cf3a44cd8c17958a595198b5ea9492cd0 (r29929). original commit message: Adds interpreter entry and exit trampoline builtins. Also implements the Return bytecode handler and fixes a few bugs in InterpreterAssembler highlighted by running on other architectures. BUG= Committed: https://crrev.com/230d0845b7012bb404d013d0fce9d07fb83f62e2 Cr-Commit-Position: refs/heads/master@{#29943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-07-31 03:10:39 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-07-31 03:50:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271433002/1
5 years, 4 months ago (2015-07-31 03:50:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 05:22:26 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 05:22:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/230d0845b7012bb404d013d0fce9d07fb83f62e2
Cr-Commit-Position: refs/heads/master@{#29943}

Powered by Google App Engine
This is Rietveld 408576698