Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 127143003: [chromedriver] Reuse forwarded adb ports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/chromedriver/net/port_server.cc ('K') | « chrome/test/chromedriver/net/port_server_unittest.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index a80aa46baeb0f6f3be972bdec16fc25b28bb8800..ab39e44b7972b806b9b95cda93bb60e085e5c9e4 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -163,8 +163,11 @@ Status ExecuteInitSession(
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
Status status = InitSessionHelper(bound_params, session, params, value);
- if (status.IsError())
+ if (status.IsError()) {
session->quit = true;
+ if (session->chrome != NULL)
+ session->chrome->Quit();
+ }
return status;
}
« chrome/test/chromedriver/net/port_server.cc ('K') | « chrome/test/chromedriver/net/port_server_unittest.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698