Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3422)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 127143003: [chromedriver] Reuse forwarded adb ports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index 354e1e657a85c42478455e7ed77aa7913abada42..c2a8c7277d2c5d4d42ddca023914d268e8527872 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -353,7 +353,7 @@ Status LaunchAndroidChrome(
status = device_manager->AcquireSpecificDevice(
capabilities.android_device_serial, &device);
}
- if (!status.IsOk())
+ if (status.IsError())
return status;
Switches switches(capabilities.switches);
@@ -367,7 +367,7 @@ Status LaunchAndroidChrome(
switches.ToString(),
capabilities.android_use_running_app,
port);
- if (!status.IsOk()) {
+ if (status.IsError()) {
device->TearDown();
return status;
}
@@ -377,8 +377,10 @@ Status LaunchAndroidChrome(
context_getter,
socket_factory,
&devtools_client);
- if (status.IsError())
+ if (status.IsError()) {
+ device->TearDown();
return status;
+ }
chrome->reset(new ChromeAndroidImpl(devtools_client.Pass(),
devtools_event_listeners,
@@ -407,14 +409,12 @@ Status LaunchChrome(
int port = 0;
scoped_ptr<PortReservation> port_reservation;
Status port_status(kOk);
- if (port_server)
- port_status = port_server->ReservePort(&port, &port_reservation);
- else
- port_status = port_manager->ReservePort(&port, &port_reservation);
- if (port_status.IsError())
- return Status(kUnknownError, "cannot reserve port for Chrome", port_status);
if (capabilities.IsAndroid()) {
+ port_status = port_manager->ReservePortFromPool(&port, &port_reservation);
+ if (port_status.IsError())
+ return Status(kUnknownError, "cannot reserve port for Chrome",
+ port_status);
return LaunchAndroidChrome(context_getter,
port,
port_reservation.Pass(),
@@ -424,6 +424,13 @@ Status LaunchChrome(
device_manager,
chrome);
} else {
+ if (port_server)
+ port_status = port_server->ReservePort(&port, &port_reservation);
+ else
+ port_status = port_manager->ReservePort(&port, &port_reservation);
+ if (port_status.IsError())
+ return Status(kUnknownError, "cannot reserve port for Chrome",
+ port_status);
return LaunchDesktopChrome(context_getter,
port,
port_reservation.Pass(),
« no previous file with comments | « no previous file | chrome/test/chromedriver/net/port_server.h » ('j') | chrome/test/chromedriver/net/port_server.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698