Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1271313006: Remove an outdated timeupdate hack android uses to start video painting (Closed)

Created:
5 years, 4 months ago by qinmin
Modified:
5 years, 4 months ago
Reviewers:
xhwang
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an outdated timeupdate hack android uses to start video painting OnTimeChanged() no longer setDisplayMode(), so this hack is no longer working for quite some time. Media element should know when to start painting the video frame when playback state changes. BUG=504773 Committed: https://crrev.com/c6145c33172101a41953d6c9e2a6939345901949 Cr-Commit-Position: refs/heads/master@{#342724}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
5 years, 4 months ago (2015-08-10 21:49:29 UTC) #2
xhwang
lgtm
5 years, 4 months ago (2015-08-10 21:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271313006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271313006/1
5 years, 4 months ago (2015-08-10 21:56:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 23:00:43 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 23:01:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6145c33172101a41953d6c9e2a6939345901949
Cr-Commit-Position: refs/heads/master@{#342724}

Powered by Google App Engine
This is Rietveld 408576698