Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1271313003: Allow execution of JavaScript in Distiller pages. (Closed)

Created:
5 years, 4 months ago by arjunpatel
Modified:
5 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow execution of JavaScript in Distiller pages. We inject JavaScript into the distiller pages when we load them for printing, so this exception is needed. Related change https://codereview.chromium.org/1125343004/ BUG=490809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Vitaly Buka (NO REVIEWS)
LGTM +jochen, as author of https://codereview.chromium.org/1258593002
5 years, 4 months ago (2015-08-05 23:12:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271313003/1
5 years, 4 months ago (2015-08-05 23:31:52 UTC) #5
commit-bot: I haz the power
The author arjunpatel@hp.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 4 months ago (2015-08-05 23:31:54 UTC) #7
jochen (gone - plz use gerrit)
5 years, 4 months ago (2015-08-06 05:01:08 UTC) #8
not lgtm

- content must not know about the distiller, as it's a higher-level concept
- the distiller cannot guarantee that all javascript from the original website
is stripped, so it's in general not safe to interact with the main world.

please run your script in the same isolated world as the rest of the chrome
distiller does.

Powered by Google App Engine
This is Rietveld 408576698