Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1431)

Unified Diff: content/public/renderer/document_state.h

Issue 12713007: Fix the no password save issue for ajax login (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unneeded test variable Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/renderer/document_state.h
diff --git a/content/public/renderer/document_state.h b/content/public/renderer/document_state.h
index 3168776091b29b201cc96eb423520d007bce50b2..d93b9619d21f8e176c9324d028c62c24e21689ff 100644
--- a/content/public/renderer/document_state.h
+++ b/content/public/renderer/document_state.h
@@ -169,6 +169,15 @@ class DocumentState : public WebKit::WebDataSource::ExtraData {
searchable_form_encoding_ = encoding;
}
+ // If set, contains the PasswordForm that we believe triggered the current
+ // navigation (there is some ambiguity in the case of javascript initiated
+ // navigations). This information is used by the PasswordManager to determine
+ // if the user should be prompted to save their password.
+ //
+ // Note that setting this field doesn't affect where the data is sent or what
+ // origin we associate it with, only if we prompt the user to save it.
Charlie Reis 2013/03/27 05:15:04 nit: if -> whether
Garrett Casto 2013/03/27 18:59:44 Done.
+ // That is, a false positive is a usability issue (e.g. may try to save a
+ // mis-typed password) not a security issue.
PasswordForm* password_form_data() const {
return password_form_data_.get();
}

Powered by Google App Engine
This is Rietveld 408576698