Fix the no password save issue for ajax login

content/public/renderer/document_state.h

Index: content/public/renderer/document_state.h
diff --git a/content/public/renderer/document_state.h b/content/public/renderer/document_state.h
index 3168776091b29b201cc96eb423520d007bce50b2..075cda010e98cc31e9e2125cb7ab148e1c227f62 100644
--- a/content/public/renderer/document_state.h
+++ b/content/public/renderer/document_state.h
@@ -169,6 +169,10 @@ class DocumentState : public WebKit::WebDataSource::ExtraData {
     searchable_form_encoding_ = encoding;
   }
 
+  // If set, contains the PasswordForm that we believe triggered the current
+  // navigation (there is some ambiguity in the case of javascript initiated

[Charlie Reis, 2013/03/23 01:00:26]

I really appreciate this comment.

However, it's also concerning.  Ambiguity suggests we could end up sending the
password to the wrong place.  If that's not possible, please update the comment
to say what safeguards are in place to prevent this.  (For example, are we
conservative here by never including password data when it's ambiguous?)

[Garrett Casto, 2013/03/26 00:00:27]

I'm not sure what you mean by sending here. If you mean sending over the wire,
this code has no control over that. If you mean populating this field, then
there are no particular safeguards other than the fact that the ambiguous case
should be rare and the side effects are limited.

To be clear, the issue occurs if the user clicks on a submit button for a form
but the form doesn't submit (either thought the normal submit process or using
XHR in the onsubmit handler, perhaps because the form failed validation). If the
user later leaves the current page due to a NavigationGestureAuto, then we will
prompt the user to save the data that they had filled out in the form when they
clicked submit.

I've added some additional comments here. Hopefully this helps.

+  // navigations). This information is used by the PasswordManager to determine
+  // if the user should be prompted to save their password.
   PasswordForm* password_form_data() const {
     return password_form_data_.get();
   }