Fix the no password save issue for ajax login

content/public/renderer/document_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_DOCUMENT_STATE_H_
 #define CONTENT_PUBLIC_RENDERER_DOCUMENT_STATE_H_
 
 #include <string>
 
 #include "base/logging.h"
@@ skipping 151 matching lines @@
 
   const GURL& searchable_form_url() const { return searchable_form_url_; }
   void set_searchable_form_url(const GURL& url) { searchable_form_url_ = url; }
   const std::string& searchable_form_encoding() const {
     return searchable_form_encoding_;
   }
   void set_searchable_form_encoding(const std::string& encoding) {
     searchable_form_encoding_ = encoding;
   }
 
+  // If set, contains the PasswordForm that we believe triggered the current
+  // navigation (there is some ambiguity in the case of javascript initiated

[Charlie Reis, 2013/03/23 01:00:26]

I really appreciate this comment.

However, it's also concerning.  Ambiguity suggests we could end up sending the
password to the wrong place.  If that's not possible, please update the comment
to say what safeguards are in place to prevent this.  (For example, are we
conservative here by never including password data when it's ambiguous?)

[Garrett Casto, 2013/03/26 00:00:27]

I'm not sure what you mean by sending here. If you mean sending over the wire,
this code has no control over that. If you mean populating this field, then
there are no particular safeguards other than the fact that the ambiguous case
should be rare and the side effects are limited.

To be clear, the issue occurs if the user clicks on a submit button for a form
but the form doesn't submit (either thought the normal submit process or using
XHR in the onsubmit handler, perhaps because the form failed validation). If the
user later leaves the current page due to a NavigationGestureAuto, then we will
prompt the user to save the data that they had filled out in the form when they
clicked submit.

I've added some additional comments here. Hopefully this helps.

+  // navigations). This information is used by the PasswordManager to determine
+  // if the user should be prompted to save their password.
   PasswordForm* password_form_data() const {
     return password_form_data_.get();
   }
   void set_password_form_data(scoped_ptr<PasswordForm> data);
 
   const std::string& security_info() const { return security_info_; }
   void set_security_info(const std::string& security_info) {
     security_info_ = security_info;
   }
 
@@ skipping 123 matching lines @@
   scoped_ptr<webkit_glue::AltErrorPageResourceFetcher> alt_error_page_fetcher_;
 
   scoped_ptr<NavigationState> navigation_state_;
 
   bool can_load_local_resources_;
 };
 
 #endif  // CONTENT_PUBLIC_RENDERER_DOCUMENT_STATE_H_
 
 }  // namespace content