Fix the no password save issue for ajax login

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 3413 matching lines @@
   }
 
   // Start time is only set after request time.
   document_state->set_start_load_time(Time::Now());
 
   bool is_top_most = !frame->parent();
   if (is_top_most) {
     navigation_gesture_ = WebUserGestureIndicator::isProcessingUserGesture() ?
         NavigationGestureUser : NavigationGestureAuto;
 
+    // If the navigation is not triggered by user gesture, e.g. by some ajax

[Ilya Sherman, 2013/03/22 03:26:48]

nit: "by user gesture" -> "by a user gesture"

[Garrett Casto, 2013/03/22 21:05:05]

Done.

+    // callback, then inherit the submitted password form from the previous
+    // state. This fixes the no password save issue for ajax login, tracked in
+    // crbug/43219. Note that there are still some sites that this fails for

[Ilya Sherman, 2013/03/22 03:26:48]

nit: Add "http://", and ideally find some way to separate the dot from the URL,
e.g. "[ http://crbug.com/43219 ].", so that linkified code is likely to work
correctly.

[Garrett Casto, 2013/03/22 21:05:05]

Done.

+    // because they use some element other than a submit button to trigger
+    // submission.
+    if (navigation_gesture_ == NavigationGestureAuto) {
+      DocumentState* document_state_old = DocumentState::FromDataSource(
+          frame->dataSource());
+      const content::PasswordForm* password_form_old =
+          document_state_old->password_form_data();
+      if (password_form_old) {
+        document_state->set_password_form_data(
+            scoped_ptr<content::PasswordForm>(

[Ilya Sherman, 2013/03/22 03:26:48]

nit: Consider using make_scoped_ptr() here.

[Garrett Casto, 2013/03/22 21:05:05]

Done.

+                new content::PasswordForm(*password_form_old)));
+      }
+    }
+
     // Make sure redirect tracking state is clear for the new load.
     completed_client_redirect_src_ = Referrer();
   } else if (frame->parent()->isLoading()) {
     // Take note of AUTO_SUBFRAME loads here, so that we can know how to
     // load an error page.  See didFailProvisionalLoad.
     document_state->navigation_state()->set_transition_type(
         PAGE_TRANSITION_AUTO_SUBFRAME);
   }
 
   FOR_EACH_OBSERVER(
@@ skipping 3246 matching lines @@
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 void RenderViewImpl::DidCommitCompositorFrame() {
   RenderWidget::DidCommitCompositorFrame();
   FOR_EACH_OBSERVER(RenderViewObserver, observers_, DidCommitCompositorFrame());
 }
 
 }  // namespace content