Change password form UI for no accounts stored case

chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
 
 #include "base/timer/timer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
@@ skipping 375 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(PendingView);
 };
 
 ManagePasswordsBubbleView::PendingView::PendingView(
     ManagePasswordsBubbleView* parent)
     : parent_(parent) {
   views::GridLayout* layout = new views::GridLayout(this);
   layout->set_minimum_size(gfx::Size(kDesiredBubbleWidth, 0));
   SetLayoutManager(layout);
 
-  std::vector<const autofill::PasswordForm*> credentials(
-      1, &parent->model()->pending_password());
   // Create the pending credential item, save button and refusal combobox.
-  ManagePasswordItemsView* item =
-      new ManagePasswordItemsView(parent_->model(), credentials);
   save_button_ = new views::BlueButton(
       this, l10n_util::GetStringUTF16(IDS_PASSWORD_MANAGER_SAVE_BUTTON));
   save_button_->SetFontList(ui::ResourceBundle::GetSharedInstance().GetFontList(
       ui::ResourceBundle::SmallFont));
 
   combobox_model_.reset(new SavePasswordRefusalComboboxModel);
   refuse_combobox_.reset(new views::Combobox(combobox_model_.get()));
   refuse_combobox_->set_listener(this);
   refuse_combobox_->SetStyle(views::Combobox::STYLE_ACTION);
   // TODO(mkwst): Need a mechanism to pipe a font list down into a combobox.
 
   // Title row.
   views::StyledLabel* title_label =
       new views::StyledLabel(parent_->model()->title(), this);
   title_label->SetBaseFontList(
       ui::ResourceBundle::GetSharedInstance().GetFontList(
           ui::ResourceBundle::MediumFont));
   if (!parent_->model()->title_brand_link_range().is_empty()) {
     title_label->AddStyleRange(
         parent_->model()->title_brand_link_range(),
         views::StyledLabel::RangeStyleInfo::CreateForLink());
   }
   BuildColumnSet(layout, SINGLE_VIEW_COLUMN_SET);
   layout->StartRow(0, SINGLE_VIEW_COLUMN_SET);
   layout->AddView(title_label);
   layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
 
   // Credential row.
-  layout->StartRow(0, SINGLE_VIEW_COLUMN_SET);
-  layout->AddView(item);
+  if (!parent->model()

[vasilii, 2015/08/05 16:28:26]

Please no new line here.

[dvadym, 2015/08/05 16:51:45]

Done.

+           ->pending_password()
+           .IsPossibleChangePasswordFormWithoutUsername()) {
+    std::vector<const autofill::PasswordForm*> credentials(
+        1, &parent->model()->pending_password());
+    ManagePasswordItemsView* item =
+        new ManagePasswordItemsView(parent_->model(), credentials);

[vasilii, 2015/08/05 16:28:26]

Can you split this and initialize |item| above?

[dvadym, 2015/08/05 16:51:45]

Done.

+    layout->StartRow(0, SINGLE_VIEW_COLUMN_SET);
+    layout->AddView(item);
+  }
 
   // Button row.
   BuildColumnSet(layout, DOUBLE_BUTTON_COLUMN_SET);
   layout->StartRowWithPadding(
       0, DOUBLE_BUTTON_COLUMN_SET, 0, views::kRelatedControlVerticalSpacing);
   layout->AddView(save_button_);
   layout->AddView(refuse_combobox_.get());
 
   // Extra padding for visual awesomeness.
   layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
@@ skipping 797 matching lines @@
 void ManagePasswordsBubbleView::NotifyNeverForThisSiteClicked() {
   if (model()->local_credentials().empty()) {
     // Skip confirmation if there are no existing passwords for this site.
     NotifyConfirmedNeverForThisSite();
   } else {
     model()->OnConfirmationForNeverForThisSite();
     Refresh();
     SizeToContents();
   }
 }