Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1271243003: CrossThreadPersistent invalidation: add missing orphaned check. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CrossThreadPersistent invalidation: add missing orphaned check. The main thread may well be detached before other Oilpan-attached threads. Its orphaned heap pages must consequently be checked for when doing later invalidation of thread-local CrossThreadPersistent<>s. R=haraken BUG=517031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200046

Patch Set 1 #

Patch Set 2 : add unit test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M Source/platform/heap/HeapTest.cpp View 1 1 chunk +48 lines, -0 lines 0 comments Download
M Source/platform/heap/PersistentNode.cpp View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
sof
please take a look.
5 years, 4 months ago (2015-08-05 13:15:21 UTC) #2
haraken
LGTM https://codereview.chromium.org/1271243003/diff/20001/Source/platform/heap/PersistentNode.cpp File Source/platform/heap/PersistentNode.cpp (right): https://codereview.chromium.org/1271243003/diff/20001/Source/platform/heap/PersistentNode.cpp#newcode126 Source/platform/heap/PersistentNode.cpp:126: if (page->heap()->threadState() == threadState) ah, page->heap() should be ...
5 years, 4 months ago (2015-08-05 14:22:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1271243003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1271243003/20001
5 years, 4 months ago (2015-08-05 14:26:51 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 14:35:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200046

Powered by Google App Engine
This is Rietveld 408576698