chrome/browser/task_manager/task_manager_browsertest_util.cc - Issue 12712018: Fixing problem with incomplete browser windows showing up after task manager was used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_browsertest_util.cc

Issue 12712018: Fixing problem with incomplete browser windows showing up after task manager was used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactored the ShowTaskManager function is requested Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_manager/task_manager_browsertest.cc ('k') | chrome/browser/task_manager/task_manager_notification_browsertest.cc » ('j') | chrome/browser/ui/ash/chrome_shell_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_browsertest_util.cc

diff --git a/chrome/browser/task_manager/task_manager_browsertest_util.cc b/chrome/browser/task_manager/task_manager_browsertest_util.cc

index 7a01c9af894ed3ab7a210f060a51d6ac07fb25ea..10e64c55aa0edc15a15155049b92accaaf5c294b 100644

--- a/chrome/browser/task_manager/task_manager_browsertest_util.cc

+++ b/chrome/browser/task_manager/task_manager_browsertest_util.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/task_manager/task_manager.h"

#include "chrome/browser/task_manager/task_manager_browsertest_util.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/test/base/ui_test_utils.h"

@@ -96,6 +97,6 @@ void TaskManagerBrowserTestUtil::WaitForWebResourceChange(int target_count) {

// static

void TaskManagerBrowserTestUtil::ShowTaskManagerAndWaitForReady(

sky 2013/03/20 23:52:08 Nuke this since it's just a call through to ShowTa

Mr4D (OOO till 08-26) 2013/03/21 00:20:10 Done.

Browser* browser) {

- browser->window()->ShowTaskManager();

+ chrome::ShowTaskManager(browser, false);

}