Fixing problem with incomplete browser windows showing up after task manager was used

chrome/browser/ui/ash/chrome_shell_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/chrome_shell_delegate.h"
 
 #include "ash/ash_switches.h"
 #include "ash/host/root_window_host_factory.h"
 #include "ash/launcher/launcher_types.h"
 #include "ash/magnifier/magnifier_constants.h"
@@ skipping 147 matching lines @@
       chrome::FocusNextPane(browser);
       break;
     case ash::Shell::BACKWARD:
       chrome::FocusPreviousPane(browser);
       break;
   }
   return true;
 }
 
 void ChromeShellDelegate::ShowTaskManager() {
-  Browser* browser = chrome::FindOrCreateTabbedBrowser(
-      ProfileManager::GetDefaultProfileOrOffTheRecord(),
-      chrome::HOST_DESKTOP_TYPE_ASH);
+  Browser* browser = chrome::FindTabbedBrowser(
+                          ProfileManager::GetDefaultProfileOrOffTheRecord(),
+                          false,
+                          chrome::HOST_DESKTOP_TYPE_ASH);

[sky, 2013/03/21 00:48:07]

This isn't quite what I think should happen either. But, it doesn't really
matter here so go back to NULL.

[Mr4D (OOO till 08-26), 2013/03/21 00:53:36]

Okay - in that case I am not sure what you wanted. But Okay - passing NULL
again. Done!

[sky, 2013/03/21 15:53:20]

Here is what I meant:

aura::Window* active = ash::wm::GetActiveWindow();
Browser* active_browser = NULL;
while (active && !active_browser) {
  active_browser = GetBrowserViewForNativeWindow(active);
  active = active->parent();
}
chrome::OpenTaskManager(browser, false);

But TaskManagerView::Show doesn't really need a browser, it needs a context for
where to create the window and the host desktop type. So, providing a views
specific variant that takes this would be better.
ChromeShellDelegate::ShowTaskManager would become:

OpenViewsTaskManager(ash::Shell::GetActiveRootWindow(), HOST_DESKTOP_TYPE_ASH,
false);

And view's implementation of OpenTaskManager would call through to
OpenViewsTaskManager:

OpenViewsTaskManager(browser->window()->GetNativeWindow(),
browser->host_desktop_type(), show_background);

This is better in that it means it's clear the TaskManager code only needs a
gfx::NativeWindow and HostDesktopType, not a Browser which could have other
random dependencies.

But anyway, passing in NULL is fine here too.

   chrome::OpenTaskManager(browser, false);
 }
 
 content::BrowserContext* ChromeShellDelegate::GetCurrentBrowserContext() {
   return ProfileManager::GetDefaultProfile();
 }
 
 app_list::AppListViewDelegate*
     ChromeShellDelegate::CreateAppListViewDelegate() {
   DCHECK(ash::Shell::HasInstance());
@@ skipping 149 matching lines @@
 }
 
 Browser* ChromeShellDelegate::GetTargetBrowser() {
   Browser* browser = chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow());
   if (browser)
     return browser;
   return chrome::FindOrCreateTabbedBrowser(
       ProfileManager::GetDefaultProfileOrOffTheRecord(),
       chrome::HOST_DESKTOP_TYPE_ASH);
 }