Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 12712011: Merge 145726 "Fix body background image geometry calculation" (Closed)

Created:
7 years, 9 months ago by pdr.
Modified:
7 years, 9 months ago
Reviewers:
pdr
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145726 "Fix body background image geometry calculation" > Fix body background image geometry calculation > https://bugs.webkit.org/show_bug.cgi?id=112226 > > Reviewed by Stephen Chenney. > > Source/WebCore: > > Images that depend on a container size require a call to set the container size before > rendering, and a call to look up the correct image during painting. > > The body's renderer is special in that it may not be the renderer that actually paints its > background. This patch fixes a bug where the correct RenderObject was used for looking up > the image, but not for setting the container size. This fixes SVG background images on body. > > Test: svg/as-background-image/svg-as-background-body.html > > * rendering/RenderBoxModelObject.cpp: > (WebCore::RenderBoxModelObject::paintFillLayerExtended): > (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): > > This change introduces clientForBackgroundImage in the background geometry calculation. > This is very similar to how the client is looked up in paintFillLayerExtended. > > * rendering/RenderBoxModelObject.h: > > The new signature for calculateBackgroundImageGeometry now mirrors > paintFillLayerExtended, containing a parameter for the correct background renderer. > > (RenderBoxModelObject): > > LayoutTests: > > This test is required to have a repeating background, as we optimize non-repeating > backgrounds so the bug is not hit. A light green color is used so the text is still > readable, and gridlines are present to prove the correct container size is being used. > > * svg/as-background-image/svg-as-background-body-expected.html: Added. > * svg/as-background-image/svg-as-background-body.html: Added. > TBR=pdr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
A + LayoutTests/svg/as-background-image/svg-as-background-body.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/as-background-image/svg-as-background-body-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/rendering/RenderBoxModelObject.cpp View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pdr.
7 years, 9 months ago (2013-03-15 22:10:20 UTC) #1
pdr.
7 years, 9 months ago (2013-03-15 22:11:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r145952.

Powered by Google App Engine
This is Rietveld 408576698