An interactive tool to help find owners covering current change list.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import json
@@ skipping 15 matching lines @@
 
 from third_party import upload
 import breakpad  # pylint: disable=W0611
 import fix_encoding
 import gclient_utils
 import presubmit_support
 import rietveld
 import scm
 import subprocess2
 import watchlists
+import owners_finder
+import glob

[M-A Ruel, 2013/04/24 13:04:45]

this one is a stdlib, move it in the group above.

[Bei Zhang, 2013/04/24 16:42:01]

Done.

 
 
 DEFAULT_SERVER = 'https://codereview.appspot.com'
 POSTUPSTREAM_HOOK_PATTERN = '.git/hooks/post-cl-%s'
 DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
 GIT_INSTRUCTIONS_URL = 'http://code.google.com/p/chromium/wiki/UsingNewGit'
 CHANGE_ID = 'Change-Id:'
 
 
 # Initialized in main()
@@ skipping 1841 matching lines @@
   _, args = parser.parse_args(args)
   if args:
     parser.error('Unrecognized args: %s' % ' '.join(args))
   cl = Changelist()
   # Ensure there actually is an issue to close.
   cl.GetDescription()
   cl.CloseIssue()
   return 0
 
 
+def CMDowners(parser, args):
+  """Interactively find the owners for reviewing"""

[M-A Ruel, 2013/04/24 13:04:45]

"""interactively ...

because it's printed as-is in git cl help.

[Bei Zhang, 2013/04/24 16:42:01]

Done.

+  group = optparse.OptionGroup(parser, 'Find owners options')
+  group.add_option(
+      '--no-color',
+      action='store_true',
+      help=('Use this option to disable color output'))

[M-A Ruel, 2013/04/24 13:04:45]

help='Use this option to disable color output')

[Bei Zhang, 2013/04/24 16:42:01]

Done.

+  parser.add_option_group(group)
+  opt, args = parser.parse_args(args)

[M-A Ruel, 2013/04/24 13:04:45]

please use the same naming conversion than the others;
options, args = parser.parse_args(args)

[Bei Zhang, 2013/04/24 16:42:01]

Done.

+  cl = Changelist()
+
+  if args:
+    if len(args) > 1:

[M-A Ruel, 2013/04/24 13:04:45]

Do this check first, before creating cl.

[Bei Zhang, 2013/04/24 16:42:01]

Done.

+      parser.error('Unknown args')
+      return

[M-A Ruel, 2013/04/24 13:04:45]

not needed, remove. error() calls sys.exit()

[Bei Zhang, 2013/04/24 16:42:01]

Done.

+    base_branch = args[0]
+  else:
+    # Default to diffing against the common ancestor of the upstream branch.
+    base_branch = RunGit(['merge-base', cl.GetUpstreamBranch(), 'HEAD']).strip()
+
+  change = cl.GetChange(base_branch, None)
+  return owners_finder.OwnersFinder(
+      [f.LocalPath() for f in
+          cl.GetChange(base_branch, None).AffectedFiles()],
+      change.RepositoryRoot(),
+      fopen=file, os_path=os.path, glob=glob.glob,
+      disable_color=opt.no_color).run()
+
+
 def Command(name):
   return getattr(sys.modules[__name__], 'CMD' + name, None)
 
 
 def CMDhelp(parser, args):
   """print list of commands or help for a specific command"""
   _, args = parser.parse_args(args)
   if len(args) == 1:
     return main(args + ['--help'])
   parser.print_help()
@@ skipping 61 matching lines @@
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))